Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use TypeScript + Node 20 + vite #44

Merged
merged 3 commits into from
Feb 4, 2024
Merged

refactor: use TypeScript + Node 20 + vite #44

merged 3 commits into from
Feb 4, 2024

Conversation

timkurvers
Copy link
Member

@timkurvers timkurvers commented Jan 20, 2024 •
edited
Loading

This PR:

  • Introduces TypeScript
  • Uses vite, replacing webpack
  • Upgrades all packages reported by npm audit
  • Uses Node 20+
  • Restructures file tree:
    • Drop index-nesting (e.g. simple/Button.ts instead of simple/Button/index.mjs)
    • Scripts now live besides their components (e.g. simple/Button.script.ts instead of simple/Button/script.mjs)
    • UI Context and Root are now both prefixed with UI (to differentiate from e.g. ScriptingContext)

TODOs:

  • Update README

In the next PR:

  • Proper TypeScript types used across all files
    • Found 1044 errors in 69 files 😅
  • Verify production build (in particular the generated filenames)
  • Verify test coverage

@timkurvers timkurvers self-assigned this Jan 20, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 21, 2024 •
edited
Loading

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (cc3bbb2) 0.00% compared to head (d9382fd) 0.00%.

Files Patch % Lines
src/ui/components/simple/Frame.ts 0.00% 6 Missing ⚠️
src/ui/UIContext.ts 0.00% 1 Missing ⚠️
src/ui/components/abstract/ScriptRegion.ts 0.00% 1 Missing ⚠️
src/ui/rendering/Renderer.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@          Coverage Diff           @@
##           master     #44   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          83      83           
  Lines        3841    3841           
  Branches      537     538    +1     
======================================
  Misses       3841    3841

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timkurvers timkurvers marked this pull request as ready for review February 4, 2024 20:05
@timkurvers timkurvers merged commit 7355ac0 into master Feb 4, 2024
3 of 6 checks passed
@timkurvers timkurvers deleted the refactor/typescript branch February 4, 2024 20:06
This was referenced Feb 4, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@timkurvers timkurvers

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@timkurvers